Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODFIN-402] Fixes to finance data endpoint #1690

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[MODFIN-402] Fixes to finance data endpoint #1690

merged 2 commits into from
Feb 7, 2025

Conversation

damien-git
Copy link
Contributor

Purpose

MODFIN-402 - Update current budget value and display budget records in appropriate fiscal year in downloaded .csv allocations

Approach

  • Ensures ids do not collide with other tests
  • Fixed FY codes and series
  • Added budgetCurrentAllocation
  • Fixed the tests, taking into account that a ledger is not tied to a single fiscal year, and finance data may contain fund data without budget data

Related PRs: mod-finance-storage, mod-finance

@damien-git damien-git self-assigned this Feb 6, 2025
This was referenced Feb 6, 2025
Merged
Merged
@damien-git damien-git requested a review from a team February 6, 2025 19:20
@damien-git damien-git merged commit 9910cf1 into master Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

@azizbekxm azizbekxm azizbekxm approved these changes

Assignees

@damien-git damien-git

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damien-git @SerhiiNosko @azizbekxm