Add patch/diff file highlighting #516
Open
+233
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to update the unit tests and themes, whoops. |
|
Thanks for the PR! Sorry @SentientCoffee, this patch will have to wait because if we merge it now we'll have to fix many conflicts with the long running branch which is blocking everything. In fact I wish you hadn't updated the config, tests and themes, because it would've been easier to add them later |
|
Is it just the default config/themes/tests that would cause an issue? I can revert those if needed, I updated them because otherwise |
|
Yes please, then it will be easier to merge later
…On Fri, 14 Feb 2025 at 10:38, SentientCoffee ***@***.***> wrote:
Is it just the default config/themes/tests that would cause an issue? I
can revert those if needed, I updated them because otherwise jai
first.jai - release fails the unit tests.
—
Reply to this email directly, view it on GitHub
<#516 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4OX77QLMARCWIDEXMKKEZT2PUGEFAVCNFSM6AAAAABXBGEFJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJXG43DGMBRG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: SentientCoffee]*SentientCoffee* left a comment
(focus-editor/focus#516)
<#516 (comment)>
Is it just the default config/themes/tests that would cause an issue? I
can revert those if needed, I updated them because otherwise jai
first.jai - release fails the unit tests.
—
Reply to this email directly, view it on GitHub
<#516 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4OX77QLMARCWIDEXMKKEZT2PUGEFAVCNFSM6AAAAABXBGEFJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJXG43DGMBRG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Reverted the unit test and theme changes 👍🏻 |
|
Great, thanks. If you want a release build for yourself in the mean time, you can just disable tests temporarily. |
Added patch/diff file highlighting for easy at a glance viewing. Does not try to highlight based on language, just a simple green for additions and red for deletions, plus some extra colours for metadata. (This could be changed in the future if we did want to highlight per language since the regions I added could stay the same and just change the token colours... That would involve needing to detect language based on the file extensions of the diff'd files though which might be kind of slow, especially for large patches that involve many files.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added patch/diff file highlighting for easy at a glance viewing.
Does not try to highlight based on language, just a simple green for additions and red for deletions, plus some extra colours for metadata.
(This could be changed in the future if we did want to highlight per language since the regions I added could stay the same and just change the token colours... That would involve needing to detect language based on the file extensions of the diff'd files though which might be kind of slow, especially for large patches that involve many files.)