Validate that node_name & client_key are set when running plugins.

This gives the user a hint that their local knife.rb is not currently
set up enough (or correctly) and where to go for help (the project
website).

Closes #10
Closes #9

lib/chef/knife/server_bootstrap_base.rb

@@ -95,8 +95,29 @@ def self.included(included_class) # rubocop:disable Metrics/MethodLength
         end
       end
 
+      def run
+        validate!
+      end
+
       private
 
+      def validate!
+        knife_fail = "You did not set {{KEY}} in your knife.rb, which is a " \
+            "required setting. Please generate an initial knife.rb or read " \
+            "the setup instructions at http://fnichol.github.io/knife-server/"
+
+        # rubocop:disable Style/DeprecatedHashMethods
+        if !Chef::Config.has_key?(:node_name)
+          ui.error knife_fail.gsub(/{{KEY}}/, "node_name")
+          exit 1
+        end
+        if !Chef::Config.has_key?(:client_key)
+          ui.error knife_fail.gsub(/{{KEY}}/, "client_key")
+          exit 1
+        end
+        # rubocop:enable Style/DeprecatedHashMethods
+      end
+
       def fetch_validation_key
         credentials_client.install_validation_key
       end

lib/chef/knife/server_bootstrap_ec2.rb

@@ -60,7 +60,7 @@ class ServerBootstrapEc2 < Knife
         :proc => proc { |groups| groups.split(",") }
 
       def run
-        validate!
+        super
         config_security_group
         ec2_bootstrap.run
         fetch_validation_key
@@ -104,6 +104,8 @@ def server_dns_name
       private
 
       def validate!
+        super
+
         if config[:chef_node_name].nil?
           ui.error "You did not provide a valid --node-name value."
           exit 1

lib/chef/knife/server_bootstrap_linode.rb

@@ -52,7 +52,7 @@ class ServerBootstrapLinode < Knife
       end
 
       def run
-        validate!
+        super
         linode_bootstrap.run
         fetch_validation_key
         create_root_client
@@ -92,6 +92,8 @@ def server_ip_address
       private
 
       def validate!
+        super
+
         if config[:chef_node_name].nil?
           ui.error "You did not provide a valid --node-name value."
           exit 1

lib/chef/knife/server_bootstrap_openstack.rb

@@ -52,7 +52,7 @@ class ServerBootstrapOpenstack < Knife
       end
 
       def run
-        validate!
+        super
         openstack_bootstrap.run
         fetch_validation_key
         create_root_client
@@ -96,6 +96,8 @@ def server_ip_address
       private
 
       def validate!
+        super
+
         if config[:chef_node_name].nil?
           ui.error "You did not provide a valid --node-name value."
           exit 1

lib/chef/knife/server_bootstrap_standalone.rb

@@ -46,7 +46,7 @@ class ServerBootstrapStandalone < Knife
         :description => "Hostname or IP address of host to bootstrap"
 
       def run
-        validate!
+        super
         check_ssh_connection
         standalone_bootstrap.run
         fetch_validation_key
@@ -73,6 +73,8 @@ def standalone_bootstrap
       private
 
       def validate!
+        super
+
         if config[:chef_node_name].nil?
           ui.error "You did not provide a valid --node-name value."
           exit 1

spec/chef/knife/server_bootstrap_ec2_spec.rb

@@ -250,6 +250,18 @@
     let(:ssh)             { double }
     let(:credentials)     { double.as_null_object }
 
+    it "exits if Chef::Config[:node_name] is missing" do
+      Chef::Config.delete(:node_name)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
+    it "exits if Chef::Config[:client_key] is missing" do
+      Chef::Config.delete(:client_key)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
     it "exits if node_name option is missing" do
       def @knife.exit(_); end
       @knife.config.delete(:chef_node_name)

spec/chef/knife/server_bootstrap_linode_spec.rb

@@ -225,6 +225,18 @@
     let(:ssh)         { double }
     let(:credentials) { double.as_null_object }
 
+    it "exits if Chef::Config[:node_name] is missing" do
+      Chef::Config.delete(:node_name)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
+    it "exits if Chef::Config[:client_key] is missing" do
+      Chef::Config.delete(:client_key)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
     it "exits if node_name option is missing" do
       @knife.config.delete(:chef_node_name)
 

spec/chef/knife/server_bootstrap_openstack_spec.rb

@@ -228,6 +228,12 @@
     let(:ssh)         { double }
     let(:credentials) { double.as_null_object }
 
+    it "exits if Chef::Config[:client_key] is missing" do
+      Chef::Config.delete(:client_key)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
     it "exits if node_name option is missing" do
       @knife.config.delete(:chef_node_name)
 

spec/chef/knife/server_bootstrap_standalone_spec.rb

@@ -241,6 +241,18 @@
     let(:ssh)         { double(:exec! => true) }
     let(:credentials) { double.as_null_object }
 
+    it "exits if Chef::Config[:node_name] is missing" do
+      Chef::Config.delete(:node_name)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
+    it "exits if Chef::Config[:client_key] is missing" do
+      Chef::Config.delete(:client_key)
+
+      expect { @knife.run }.to raise_error SystemExit
+    end
+
     it "exits if node_name option is missing" do
       @knife.config.delete(:chef_node_name)