Fix aggregate functions #1325
Merged
Fix aggregate functions #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally validate the data type of a pointer value in a function call. Until now, only the type (tag) of a pointer value was checked, but not the real data type.
fnc12
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate function objects must be created per aggregate context and not per result row.
Also, due to allocation errors,
sqlite3_aggregate_context()may return anullptr, and the standard allocator may triggerstd::bad_allocwhen creating the aggregate function object. This situation is translated into a SQLite query error.Furthermore, the C++ data type of a pointer value in a function call is validated in addition to its SQLite pointer type (tag).