Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Epic moved the Chat system from xmpp to eos connect and its own api #776

Merged
merged 8 commits into from
Aug 3, 2024

Conversation

LeleDerGrasshalmi
Copy link
Contributor

Fixes #775

resources/structs.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tnfAngel tnfAngel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes and everything seems to works correctly. For those who upgrade, please note that there is now a length limit of 256 characters when sending a message.

Hoping this great PR gets merged.

@AntogamerYT
Copy link

image

Works 👍🏻 though it throws an error when the bot is alone in the party:

                    throw new EpicgamesAPIError_1.default(err.response.data, config, err.response.status);
                          ^

EpicgamesAPIError: User [REDACTED] is not member of the conversation

(REDACTED being the bot's accountId)

@LeleDerGrasshalmi
Copy link
Contributor Author

LeleDerGrasshalmi commented Jul 26, 2024

hi @AntogamerYT, the latest update should now throw a PartyChatConversationNotFoundError error when there are no other party members.

Copy link
Member

@ThisNils ThisNils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One small change request 🙂

src/exceptions/PartyChatConversationNotFound.ts Outdated Show resolved Hide resolved
@ThisNils ThisNils merged commit f2a83f1 into fnbrjs:main Aug 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EOS Connect] Epic moved the Chat system from xmpp to eos connect and its own api
5 participants