Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node typescript types #701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add node typescript types #701

wants to merge 1 commit into from

Conversation

demedos
Copy link

@demedos demedos commented Jan 20, 2023

Adds missing typescript declarations, fixing the above issues:

error: Cannot find module 'fs' or its corresponding type declarations. ts(2307)
warning: Could not find a declaration file for module 'glob'. ts(7016)

This also adds type checking and intellisense support.

I also commited the yarn.lock as it's a best practice to have identical builds on different machines, as per documentation

It is highly recommended you commit the generated package lock to source control: this will allow anyone else on your team, [...] to get the exact same dependency tree that you were developing on.

@demedos demedos requested a review from fnando as a code owner January 20, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant