Various potential merges to cherry pick. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposed Occlusion details on the PlayEventAttached blueprint callable function.
…gh to FMOD Listener Attenuation is now set by default to the Player Controller "Controlled Pawn" PawnViewPoint. This is overrideable on pawns. For example in a third person game, you might want the panning to be at the camera location, but the attenuation to be from the character's head location, meaning that a world sound doesn't get louder and quieter just from orbiting the camera around the controlled pawn.
…erface to allow for virtual overrides. Changed FMODAudioComponent.h access specifiers for ActorComponent interface from private to protected to allow for virtual overrides.
|
Forgive me - I'm getting used to how Github does pull requests. I've accidentally committed multiple changes here. The 2 I'm primary interested in committing are d5dd167 for changing access specifiers for ActorComponent interface, and potentially 54f48c9 if occlusion details for PlayEventAttached is desired. |
…n simulating in editor. By default, FMOD doesn't allow for flying around in editor to hear the world sounds. This change allows for the editor viewport position to be used as the world listener position during UpdateListeners so that audio designers can fly around their worlds in simulation to hear things properly.
In addition to a previous CL for allowing audio in viewports during "simulation". This CL ensures that only the active viewport (if multiple are open) during simulation updates the listener Transform.
AgentMilkshake1
changed the title
|
The final 2 commits here allow for the editor viewport camera to act as the listener position during simulation (with only the active viewport setting the transform in the case that multiple viewports are open). |
|
Hi, Thank you for the suggestions, we really appreciate all the ideas! I will pass them on to our development team to look into further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed Occlusion details on the PlayEventAttached blueprint callable function.