Fix override_refines container iteration crash.

[ursg]

This is one of those "how did this ever work" crashes?
Instead of iterating through a container while modifying it, use std::erase_if.

[markusbattarbee]

Same fix for line 9622?

[ursg]

Ah, good catch.

[markusbattarbee]

so would std::remove_if() work in order to not require C++20 as that isn't yet available on all our platforms?

[lkotipal]

Right, std::erase_if() should just be shorthand for erase-remove.