plot_colormap3dslice overlays fSaved, fluxrope and AMR levels #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raight cell edges instead of interpolated contours.
ykempf
commented
Oct 5, 2023
| fRmap = np.ma.array(fRmap, mask=XYmask) | ||
|
|
||
| # vg_fluxrope goes to the max defined at runtime, set the values above our cutoff to zero for clean results. | ||
| fRmap = np.where(fRmap > fluxrope, np.zeros_like(fRmap), fRmap) |
There was a problem hiding this comment.
At least this line is one that's not needed/used by the others, but sure can also be implemented in some function that would do this in a more generic way.
|
I think this would be a good place to add some modularity, i.e. make a function which takes the data, contour points, linestyles and axes and then does this by-cell-edges plotting. Then we could re-use it for 2D plotting tools as well, as well as threeslice etc. (and include a check inside that function to return without doing anything if there isn't any points passing that contour value). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now done with straight cell edges instead of interpolated contours.
Example: