Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making ParseError and ValidationError public #102

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Making ParseError and ValidationError public #102

merged 4 commits into from
Feb 5, 2024

Conversation

msdrigg
Copy link
Contributor

@msdrigg msdrigg commented Feb 4, 2024

@msdrigg
Copy link
Contributor Author

msdrigg commented Feb 4, 2024

I tested this in my own repo and it's working.

@fmeringdal
Copy link
Owner

LGTM! Make sure to add an entry in CHANGELOG.md that these errors are made public and then this should be good to merge

@msdrigg
Copy link
Contributor Author

msdrigg commented Feb 4, 2024

Done

fmeringdal
fmeringdal requested changes Feb 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@fmeringdal fmeringdal merged commit 7ebdf3d into fmeringdal:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeringdal fmeringdal fmeringdal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msdrigg @fmeringdal