-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unified parsing #53
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 89.24% 0.00% -89.25%
==========================================
Files 6 7 +1
Lines 251 255 +4
==========================================
- Hits 224 0 -224
- Misses 27 255 +228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fair. @nspielbau would you mind having a look at my small comments?
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
I also added a check to skip over empty splits, as the session creation failed otherwise. We can drop that if we don't want that |
During testing, I realized that the 'tiled' window of the example session was not initialized correctly with this command parsing. I will take a look at that |
See #51