feat(config): lock mqtt prefix if new data is created

Signed-off-by: Domingo Oropeza <[email protected]>
flyve-mdm · May 15, 2018 · b6b28a0 · b6b28a0
1 parent 44a68e3
commit b6b28a0
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 2 deletions.
diff --git a/inc/agent.class.php b/inc/agent.class.php
@@ -548,6 +548,10 @@ public function prepareInputForUpdate($input) {
    public function post_addItem() {
       // Notify the agent about its fleets
       $this->updateSubscription();
+
+      if (PluginFlyvemdmConfig::canUpdate()) {
+         // Here we must update mqtt_prefix_locked
+      }
    }
 
    public function post_getFromDB() {

diff --git a/inc/config.class.php b/inc/config.class.php
@@ -531,4 +531,11 @@ public function isGlpiConfigured() {
 
       return true;
    }
+
+   public function prepareInputForUpdate($input) {
+      if ($input['mqtt_prefix'] != $this->fields['mqtt_prefix'] && $this->fields['mqtt_prefix_locked'] == 0) {
+         $input['mqtt_prefix_locked'] = 1;
+      }
+      return $input;
+   }
 }
diff --git a/inc/fleet.class.php b/inc/fleet.class.php
@@ -315,6 +315,10 @@ public function post_addItem() {
          $topic = $this->getTopic();
          $this->notify("$topic/Policy/$policyName", null, 0, 1);
       }
+
+      if (PluginFlyvemdmConfig::canUpdate()) {
+         // Here we must update mqtt_prefix_locked
+      }
    }
 
    /**

diff --git a/inc/invitation.class.php b/inc/invitation.class.php
@@ -244,6 +244,10 @@ public function post_addItem() {
 
       // Sent invitation email
       $this->sendInvitation();
+
+      if (PluginFlyvemdmConfig::canUpdate()) {
+         // Here we must update mqtt_prefix_locked
+      }
    }
 
    public function post_updateItem($history = 1) {

diff --git a/install/installer.class.php b/install/installer.class.php
@@ -601,6 +601,7 @@ protected function createInitialConfig() {
          'mqtt_user'                       => self::BACKEND_MQTT_USER,
          'mqtt_passwd'                     => $MdmMqttPassword,
          'mqtt_prefix'                     => '',
+         'mqtt_prefix_locked'              => '0',
          'instance_id'                     => $instanceId,
          'registered_profiles_id'          => '',
          'guest_profiles_id'               => '',

diff --git a/tpl/config-messagequeue.html.twig b/tpl/config-messagequeue.html.twig
@@ -22,8 +22,12 @@
       </tr>
       <tr class="tab_bg_1">
          <td>{{ __('MQTT prefix', 'flyvemdm') }}</td>
-         <td><input type="text" name="mqtt_prefix" value="{{ config.mqtt_prefix }}"></td>
-         <td>{{ __('Prepend all topics with a prefix (useful if a MQTT broker is mutualized). The mqtt daemon must be restarted.', 'flyvemdm') }}</td>
+         <td><input type="text" name="mqtt_prefix" value="{{ config.mqtt_prefix }}"
+                    {% if (config.mqtt_prefix_locked) == 1 %}disabled{% endif %}></td>
+         <td>{{ __('Prepend all topics with a prefix (useful if a MQTT broker is mutualized). The mqtt daemon must be restarted after the change.', 'flyvemdm') }}
+            <br>
+            <span class="red">{{ __('Note: This value can be changed only once and if no new invitation, agent or fleet has been created.', 'flyvemdm') }}</span>
+         </td>
       </tr>
       <tr class="tab_bg_1">
          <td>{{ __('MQTT broker port for TLS', 'flyvemdm') }}</td>