Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update neptune description #1744

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Update neptune description #1744

merged 2 commits into from
Oct 8, 2024
+1 −1

Conversation

thomasjpfan
Copy link
Member

Updates neptune description in docs.

@thomasjpfan
Update neptune description
ea81739 
Signed-off-by: Thomas J. Fan <[email protected]>
neverett
neverett approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but looks like there's a build error with the wandb plugin because the Dockerfile is using a legacy format for the LABEL key/value pair.

@neverett neverett mentioned this pull request Oct 8, 2024
Merged
@neverett
Copy link
Contributor

neverett commented Oct 8, 2024

Opened #1745 to fix the wandb test failure.

@thomasjpfan thomasjpfan merged commit 846ad8b into flyteorg:master Oct 8, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neverett neverett neverett approved these changes

@ppiegaze ppiegaze Awaiting requested review from ppiegaze ppiegaze is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasjpfan @neverett