Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Plugin changes for plumbing k8s events into TaskExecutionEvent #406

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

andrewwdye
Copy link
Contributor

TL;DR

State management and config changes required for plumbing k8s events into TaskExecutionEvent as part of flyteorg/flyte#3825

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This change

  1. Adds a TaskInfo.AdditionalReasons field so that propeller can append k8s event information when handling a k8s phase update.
  2. Adds a SendObjectEvents option to K8sPluginConfig so this feature can be opted into

Tracking Issue

flyteorg/flyte#3825

Follow-up issue

N/A

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (08dd79b) 62.73% compared to head (07b8e86) 64.19%.
Report is 2 commits behind head on master.

❗ Current head 07b8e86 differs from pull request most recent head 7899616. Consider uploading reports for the commit 7899616 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   62.73%   64.19%   +1.46%     
==========================================
  Files         156      156              
  Lines       13172    10705    -2467     
==========================================
- Hits         8263     6872    -1391     
+ Misses       4284     3202    -1082     
- Partials      625      631       +6     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/pluginmachinery/core/phase.go 21.50% <ø> (-1.27%) ⬇️
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
...machinery/flytek8s/config/k8spluginconfig_flags.go 51.28% <100.00%> (+3.78%) ⬆️
go/tasks/plugins/k8s/ray/config_flags.go 38.70% <100.00%> (+2.34%) ⬆️
go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
go/tasks/plugins/webapi/agent/plugin.go 68.71% <60.00%> (+2.81%) ⬆️
go/tasks/plugins/k8s/ray/ray.go 84.17% <80.00%> (+5.83%) ⬆️
go/tasks/plugins/k8s/ray/config.go 36.36% <0.00%> (-13.64%) ⬇️

... and 131 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew Dye <[email protected]>
@hamersaw hamersaw merged commit 01ebefd into flyteorg:master Sep 27, 2023
7 checks passed
eapolinario pushed a commit that referenced this pull request Sep 28, 2023
* Plugin changes for k8s events

Signed-off-by: Andrew Dye <[email protected]>

* make generate

Signed-off-by: Andrew Dye <[email protected]>

* Comment for SendObjectEvents

Signed-off-by: Andrew Dye <[email protected]>

* make generate

Signed-off-by: Andrew Dye <[email protected]>

---------

Signed-off-by: Andrew Dye <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants