This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
enable secrets in non-python k8s tasks #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
8 tasks
fellhorn
approved these changes
Sep 8, 2023
|
Thanks @hamersaw ! As pointed out in the (now closed) other PR, I think this is the cleaner solution and should be preferred! Is there a good spot to have some tests for this? |
Signed-off-by: Daniel Rammer <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 62.83% 64.21% +1.37%
==========================================
Files 156 156
Lines 13116 10657 -2459
==========================================
- Hits 8242 6843 -1399
+ Misses 4253 3192 -1061
- Partials 621 622 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Sep 8, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
* enabling secrets in non-python k8s tasks Signed-off-by: Daniel Rammer <[email protected]> * added unit tests Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Merging
objectMetawith theTaskExecutionMetadatalabels and annotations. Per this comment the required annotations to support Flytes secret injection will be present as set here.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3907
Follow-up issue
NA