Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

updated maptask log links to use original index #397

Closed
wants to merge 1 commit into from

Conversation

hamersaw
Copy link
Contributor

TL;DR

Updated the maptask log links to use the subtask original index rather than the execution index.

NOTE: This change means that log links will not match the pod name in scenarios where the subtask execution and original indicies differ (ex. cache hits).

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (13465ae) 63.00% compared to head (cb217c6) 64.36%.
Report is 12 commits behind head on master.

❗ Current head cb217c6 differs from pull request most recent head e3b4f86. Consider uploading reports for the commit e3b4f86 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   63.00%   64.36%   +1.36%     
==========================================
  Files         154      154              
  Lines       13084    10617    -2467     
==========================================
- Hits         8244     6834    -1410     
+ Misses       4222     3165    -1057     
  Partials      618      618              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/plugins/array/awsbatch/executor.go 43.75% <100.00%> (+1.19%) ⬆️
go/tasks/plugins/array/core/metadata.go 80.00% <100.00%> (-2.23%) ⬇️
go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) ⬆️
go/tasks/plugins/array/k8s/subtask_exec_context.go 83.33% <85.71%> (+1.51%) ⬆️

... and 131 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw
Copy link
Member

merge?

@eapolinario
Copy link
Contributor

eapolinario commented Oct 3, 2023

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to . Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

edit: Re-opening these PRs as the automation failed.

@eapolinario eapolinario closed this Oct 3, 2023
@eapolinario eapolinario reopened this Oct 3, 2023
@eapolinario
Copy link
Contributor

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4134. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants