This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix double http in the Spark Driver UI Link #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mucahit-kantepe <[email protected]>
Signed-off-by: mucahit-kantepe <[email protected]>
Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Mücahit Kantepe <[email protected]>
Signed-off-by: Mücahit Kantepe <[email protected]>
Signed-off-by: mucahit-kantepe <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 63.01% 64.36% +1.34%
==========================================
Files 154 154
Lines 13080 10616 -2464
==========================================
- Hits 8243 6833 -1410
+ Misses 4220 3165 -1055
- Partials 617 618 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jeevb
approved these changes
Aug 16, 2023
pingsutw
approved these changes
Aug 16, 2023
edwinyyyu
pushed a commit
to edwinyyyu/flyteplugins
that referenced
this pull request
Aug 25, 2023
* Fix double http in the Spark Driver UI Link Signed-off-by: mucahit-kantepe <[email protected]> * fix test Signed-off-by: mucahit-kantepe <[email protected]> * Apply suggestions from code review Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Mücahit Kantepe <[email protected]> * Update spark.go Signed-off-by: Mücahit Kantepe <[email protected]> * fmt Signed-off-by: mucahit-kantepe <[email protected]> * updated to append https if neither http or https prefixes spark uri Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: mucahit-kantepe <[email protected]> Signed-off-by: Mücahit Kantepe <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: mucahit-kantepe <[email protected]> Co-authored-by: Mücahit Kantepe <[email protected]> Co-authored-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Fix double http in the Spark Driver UI Link Signed-off-by: mucahit-kantepe <[email protected]> * fix test Signed-off-by: mucahit-kantepe <[email protected]> * Apply suggestions from code review Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Mücahit Kantepe <[email protected]> * Update spark.go Signed-off-by: Mücahit Kantepe <[email protected]> * fmt Signed-off-by: mucahit-kantepe <[email protected]> * updated to append https if neither http or https prefixes spark uri Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: mucahit-kantepe <[email protected]> Signed-off-by: Mücahit Kantepe <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: mucahit-kantepe <[email protected]> Co-authored-by: Mücahit Kantepe <[email protected]> Co-authored-by: Ketan Umare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Brings #347 across the finish line.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3623
Follow-up issue
NA