Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Render task template in the agent client #384

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Aug 8, 2023

TL;DR

In some cases, people want to run pyflyte-execute command in the other container orchestrator platform instead of Kubernetes by using the agent. Therefore, we should render the command before sending the request to the agent.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Render the task template in the agent plugin

Tracking Issue

NA

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #384 (4745c59) into master (c528bb8) will increase coverage by 1.36%.
The diff coverage is 76.92%.

❗ Current head 4745c59 differs from pull request most recent head dd6f042. Consider uploading reports for the commit dd6f042 to get more accurate results

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   63.00%   64.37%   +1.36%     
==========================================
  Files         154      154              
  Lines       13068    10613    -2455     
==========================================
- Hits         8234     6832    -1402     
+ Misses       4218     3164    -1054     
- Partials      616      617       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
go/tasks/plugins/webapi/agent/plugin.go 71.69% <76.92%> (+3.56%) ⬆️

... and 134 files with indirect coverage changes

Signed-off-by: Kevin Su <[email protected]>
go/tasks/plugins/webapi/agent/plugin.go Outdated Show resolved Hide resolved
go/tasks/plugins/webapi/agent/plugin.go Outdated Show resolved Hide resolved
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw merged commit 03dc9db into master Aug 9, 2023
7 checks passed
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Render task template

Signed-off-by: Kevin Su <[email protected]>

* Render task template in the agent client

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants