Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Check if ResourceMeta exists before sending the request #371

Closed
wants to merge 2 commits into from

Conversation

pingsutw
Copy link
Member

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1689004671152499

Follow-up issue

NA

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as draft July 12, 2023 07:42
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #371 (83c8962) into master (3d2525a) will increase coverage by 1.25%.
The diff coverage is 0.00%.

❗ Current head 83c8962 differs from pull request most recent head 61b6b96. Consider uploading reports for the commit 61b6b96 to get more accurate results

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   62.92%   64.17%   +1.25%     
==========================================
  Files         153      153              
  Lines       12901    10455    -2446     
==========================================
- Hits         8118     6710    -1408     
+ Misses       4170     3129    -1041     
- Partials      613      616       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/webapi/databricks/plugin.go 63.72% <0.00%> (+2.38%) ⬆️

... and 133 files with indirect coverage changes

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw closed this Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant