Support FlyteRemote.execute interruptible flag override
#2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: redartera <[email protected]>
Signed-off-by: redartera <[email protected]>
Signed-off-by: redartera <[email protected]>
Signed-off-by: redartera <[email protected]>
redartera
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: redartera <[email protected]>
Signed-off-by: redartera <[email protected]>
pingsutw
previously approved these changes
Nov 4, 2024
|
@pingsutw Can we please merge this PR? |
redartera
commented
Nov 21, 2024
auto-merge was automatically disabled
November 21, 2024 13:53
Head branch was pushed to by a user without write access
Signed-off-by: redartera <[email protected]>
redartera
force-pushed
the
flyteremote-interruptible-override
branch
from
aa09a04 to
e82b2ce
Compare
Signed-off-by: redartera <[email protected]>
|
After merging Actually I synched the master branch of my |
yes this is my fault |
Signed-off-by: redartera <[email protected]>
|
@pingsutw @Future-Outlier can you please take another look? the monodocs GH action issue seems resolved now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
===========================================
+ Coverage 51.81% 95.29% +43.47%
===========================================
Files 202 98 -104
Lines 21469 4250 -17219
Branches 2766 0 -2766
===========================================
- Hits 11125 4050 -7075
+ Misses 9735 200 -9535
+ Partials 609 0 -609 ☔ View full report in Codecov by Sentry. |
Code Review Agent Run #d114f3Actionable Suggestions - 1
Additional Suggestions - 1
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Jan 2, 2025
Code Review Agent Run #fb24f7Actionable Suggestions - 0Additional Suggestions - 10
Review Details
AI Code Review powered by |
Code Review Agent Run #b66645Actionable Suggestions - 0Additional Suggestions - 10
Review Details
AI Code Review powered by |
|
do we really need or can we remove the wrapper in the model for the bool value? it's a oneof but i think just setting the bool should be enough. could we also add it to one of the unit tests in here please?I know the model files are annoying and unnecessary to work with, thank you for bearing with us. |
Signed-off-by: redartera <[email protected]>
Signed-off-by: redartera <[email protected]>
redartera
force-pushed
the
flyteremote-interruptible-override
branch
from
47876c6 to
73cae9e
Compare
Removed the wrapper here bcbb991 edit: passing a raw |
Quick update - it seems to be indeed a Would you advise to stick with the google wrapper - or is there a better alternative? |
Code Review Agent Run #2ccc25Actionable Suggestions - 0Additional Suggestions - 1
Review Details
AI Code Review powered by |
redartera
force-pushed
the
flyteremote-interruptible-override
branch
from
2d668ea to
e2083da
Compare
|
It looks like |
Code Review Agent Run #616c34Actionable Suggestions - 0Additional Suggestions - 10
Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5279
Why are the changes needed?
It is useful for users to invoke the same
LaunchPlanbut overriding at runtime whether they need executions to be interruptible or not. Currently this is possible through the Flyte UI, but notflytekit.What changes were proposed in this pull request?
Support an
interruptibleoption inFlyteRemote.executeHow was this patch tested?
Integration test added
Check all the applicable boxes
Summary by Bito
This PR implements comprehensive system improvements including interruptible flag override in FlyteRemote, configurable chunk sizes for S3/GCS operations, and enhanced pod spec generation. Key features include runtime control of workflow interruption, Environment class implementation, and Optuna plugin integration. The changes enhance error handling across components, improve file operations with pydantic support, and strengthen security through better input validation and secret management. The PR also introduces VLLM integration, Kubernetes data service plugin, and improved async operations with configurable batch sizes.Unit tests added: True
Estimated effort to review (1-5, lower is better): 5