Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links to register #2804

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dansola
Copy link
Contributor

@dansola dansola commented Oct 10, 2024

Why are the changes needed?

When entities are registered there is no helpful link to the UI like there is when entities are run. This helps users navigate to the entity in the UI after they register something in the CLI.

What changes were proposed in this pull request?

When registering we fetch the entity with flyte remote and then get the console url for the entity.

How was this patch tested?

union register docs_examples/flyte_file.py

Before:

Successfully serialized 4 flyte objects
[✔] Registration flyte_file.t1 type TASK successful with version GxQbXiMnIdiRYRxg6I_B2Q
[✔] Registration flyte_file.t2 type TASK successful with version GxQbXiMnIdiRYRxg6I_B2Q
[✔] Registration flyte_file.wf type WORKFLOW successful with version GxQbXiMnIdiRYRxg6I_B2Q
[✔] Registration flyte_file.wf type LAUNCH_PLAN successful with version GxQbXiMnIdiRYRxg6I_B2Q
Successfully registered 4 entities

After:

Successfully serialized and registered 4 flyte objects
[✔] Task flyte_file.t1: https://dogfood.cloud-staging.union.ai/console/projects/flytesnacks/domains/development/task/flyte_file.t1/version/5DwpP5Caxf0QnJ8FlLW0Ag
[✔] Task flyte_file.t2: https://dogfood.cloud-staging.union.ai/console/projects/flytesnacks/domains/development/task/flyte_file.t2/version/5DwpP5Caxf0QnJ8FlLW0Ag
[✔] Workflow flyte_file.wf: https://dogfood.cloud-staging.union.ai/console/projects/flytesnacks/domains/development/workflow/flyte_file.wf/version/5DwpP5Caxf0QnJ8FlLW0Ag
[✔] Launch Plan flyte_file.wf: https://dogfood.cloud-staging.union.ai/console/projects/flytesnacks/domains/development/launch_plan/flyte_file.wf/version/5DwpP5Caxf0QnJ8FlLW0Ag

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Daniel Sola <[email protected]>
Signed-off-by: Daniel Sola <[email protected]>
Signed-off-by: Daniel Sola <[email protected]>
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (cd8216a) to head (a3e9b04).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/tools/repo.py 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cd8216a) and HEAD (a3e9b04). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (cd8216a) HEAD (a3e9b04)
8 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2804       +/-   ##
===========================================
- Coverage   76.82%   43.95%   -32.87%     
===========================================
  Files         196      196               
  Lines       20301    20312       +11     
  Branches     2610     2613        +3     
===========================================
- Hits        15596     8928     -6668     
- Misses       4004    11157     +7153     
+ Partials      701      227      -474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Sola <[email protected]>
Signed-off-by: Daniel Sola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant