Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip][Flyte Deck] Streaming Decks #2779

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Future-Outlier
Copy link
Member

Tracking issue

flyteorg/flyte#5574

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.52%. Comparing base (cc4d27b) to head (9b60564).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/deck/deck.py 55.55% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cc4d27b) and HEAD (9b60564). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (cc4d27b) HEAD (9b60564)
22 17
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2779       +/-   ##
===========================================
- Coverage   80.07%   53.52%   -26.56%     
===========================================
  Files         280      261       -19     
  Lines       23491    23109      -382     
  Branches     4146     4147        +1     
===========================================
- Hits        18811    12368     -6443     
- Misses       3989    10235     +6246     
+ Partials      691      506      -185     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title [Flyte Deck] Streaming Decks [wip][Flyte Deck] Streaming Decks Oct 2, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Oct 9, 2024

I would love to see an example of tqdm

@kumare3
Copy link
Contributor

kumare3 commented Oct 9, 2024

replaces #1704

@Future-Outlier
Copy link
Member Author

I would love to see an example of tqdm

will try it, just let me ship the MSGPACK IDL first.

<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it automatically refresh the page.. probably need that on the empty deck but not sure how to do the realtime behavior once it has content (you don't want to refresh while the user is browsing around or clicking through various tabs)

Suggested change
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="refresh" content="5" >

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COOL, will try it, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants