Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run CI checks using protobuf 4 #2459

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Only run CI checks using protobuf 4 #2459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a6a96c
Only run CI checks using protobuf 4
eapolinario Jun 4, 2024
89d7d53
Fix lint error
eapolinario Jun 4, 2024
edd0df1
Install the right version of types-protobuf
eapolinario Jun 4, 2024
eadc8ac
Force protobuf<5 in plugins tests
eapolinario Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pythonbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,8 @@ jobs:
cd plugins/${{ matrix.plugin-names }}
uv pip install --system .
if [ -f dev-requirements.in ]; then uv pip install --system -r dev-requirements.in; fi
uv pip install --system -U $GITHUB_WORKSPACE
# TODO: move to protobuf>=5. Github issue: https://github.com/flyteorg/flyte/issues/5448
uv pip install --system -U $GITHUB_WORKSPACE "protobuf<5"
uv pip freeze
- name: Test with coverage
run: |
Expand Down
7 changes: 6 additions & 1 deletion dev-requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ torch; python_version<'3.12'
# Once a solution is found, this should be updated to support Windows as well.
python-magic; (platform_system=='Darwin' or platform_system=='Linux')

types-protobuf
# Google released a new major version of the protobuf library and once that started being used in the ecosystem at large,
# including `googleapis-common-protos` we started seeing errors in CI, so let's constrain that for now.
# The issue to support protobuf 5 is being tracked in https://github.com/flyteorg/flyte/issues/5448.
protobuf<5
types-protobuf<5

types-croniter
types-decorator
types-mock
Expand Down
Loading