-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run task first and detect local execution #1997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
+ Coverage 85.79% 85.82% +0.02%
==========================================
Files 315 315
Lines 23351 23412 +61
Branches 3530 3530
==========================================
+ Hits 20034 20093 +59
- Misses 2713 2716 +3
+ Partials 604 603 -1 ☔ View full report in Codecov by Sentry. |
troychiu
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
November 26, 2023 20:43
ByronHsu
reviewed
Nov 26, 2023
plugins/flytekit-flyin/flytekitplugins/flyin/vscode_lib/decorator.py
Outdated
Show resolved
Hide resolved
troychiu
force-pushed
the
vscode-run-task-first
branch
from
November 27, 2023 05:00
1a52f4f
to
2e5ad01
Compare
ByronHsu
previously approved these changes
Nov 27, 2023
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
troychiu
force-pushed
the
vscode-run-task-first
branch
from
November 27, 2023 08:25
43fc0ce
to
f70d7f6
Compare
eapolinario
approved these changes
Nov 27, 2023
This was referenced Nov 28, 2023
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* Run task first and detect local execution Signed-off-by: troychiu <[email protected]> * fix log Signed-off-by: troychiu <[email protected]> * fix log Signed-off-by: troychiu <[email protected]> * lint Signed-off-by: troychiu <[email protected]> --------- Signed-off-by: troychiu <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#4284
Describe your changes
This PR introduces two enhancements to the Flyin VSCode decorator:
Check all the applicable boxes