Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vscode as flyin plugin #1986

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Nov 21, 2023

Tracking issue

flyteorg/flyte#4284

Describe your changes

Rename vscode as flyin plugin

  1. Better branding name
  2. flyin plugin will host multiple interactive interface e.g. jupyter, neovim, so naming as vscode doesn't make sense anymore

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

End to end tests

from flytekit import task, workflow
from flytekitplugins.flyin import vscode, VscodeConfig, DEFAULT_CODE_SERVER_EXTENSIONS

@task(
    container_image="localhost:30000/flytekit-cache:0.0.1",
    environment={"FLYTE_SDK_LOGGING_LEVEL": "20"}
)
@vscode(

)
def t():
    ...



# this vscode task will be killed within 10 secs
@task(
    container_image="localhost:30000/flytekit-cache:0.0.1",
    environment={"FLYTE_SDK_LOGGING_LEVEL": "20"}
)
@vscode(
    max_idle_seconds=10,
)
def t_short_live():
    ...



# this vscode task will download default extension + vim extension
config_with_vim = VscodeConfig(
    extension_remote_paths=DEFAULT_CODE_SERVER_EXTENSIONS+["https://open-vsx.org/api/vscodevim/vim/1.27.0/file/vscodevim.vim-1.27.0.vsix"]
)

@task(
    container_image="localhost:30000/flytekit-cache:0.0.1",
    environment={"FLYTE_SDK_LOGGING_LEVEL": "20"}
)
@vscode(
    config=config_with_vim
)
def t_vim():
    ...



@workflow
def wf():
    t()
    t_short_live()
    t_vim()

The above code runs as expected

image

Signed-off-by: byhsu <[email protected]>
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744c167) 85.80% compared to head (249467b) 85.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
- Coverage   85.80%   85.78%   -0.02%     
==========================================
  Files         313      313              
  Lines       23278    23279       +1     
  Branches     3526     3526              
==========================================
- Hits        19973    19971       -2     
- Misses       2702     2705       +3     
  Partials      603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ByronHsu ByronHsu merged commit ca42d97 into flyteorg:master Nov 21, 2023
72 of 74 checks passed
ringohoffman pushed a commit to ringohoffman/flytekit that referenced this pull request Nov 24, 2023
* rename vscode as flyin plugin

Signed-off-by: byhsu <[email protected]>

* fix lint

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
RRap0so pushed a commit to RRap0so/flytekit that referenced this pull request Dec 15, 2023
* rename vscode as flyin plugin

Signed-off-by: byhsu <[email protected]>

* fix lint

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants