Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] init vscode plugin #1915

Closed
wants to merge 1 commit into from

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Oct 24, 2023

TL;DR

Please replace this text with a description of what this PR accomplishes.

Init vscode plugin from LinkedIn fork (with URL masked). OSS contributor @troychiu will continue based on my work, polish it to be generic, and publish it as a flytekit plugin

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#4284

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@ByronHsu ByronHsu changed the title init init vscode plugin Oct 24, 2023
@ByronHsu ByronHsu changed the title init vscode plugin [DRAFT] init vscode plugin Oct 24, 2023
Signed-off-by: byhsu <[email protected]>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b5692a) 55.07% compared to head (7308f64) 54.68%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   55.07%   54.68%   -0.39%     
==========================================
  Files         301      301              
  Lines       22453    22612     +159     
  Branches     3371     3429      +58     
==========================================
  Hits        12366    12366              
- Misses       9922    10074     +152     
- Partials      165      172       +7     

see 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor
Copy link
Contributor

thanks byron.

@ByronHsu ByronHsu closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants