Escape $ inside the task name #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
reviewed
Feb 2, 2024
jflyte-utils/src/main/java/org/flyte/jflyte/utils/ProjectClosure.java
Outdated
Show resolved
Hide resolved
honnix
reviewed
Feb 2, 2024
jflyte-utils/src/main/java/org/flyte/jflyte/utils/ProjectClosure.java
Outdated
Show resolved
Hide resolved
honnix
approved these changes
Feb 2, 2024
Signed-off-by: Andres Gomez Ferrer <[email protected]> Fix format Signed-off-by: Andres Gomez Ferrer <[email protected]> Apply suggestions from code review Co-authored-by: Honnix <[email protected]> Signed-off-by: Andres Gomez Ferrer <[email protected]>
andresgomezfrr
force-pushed
the
fix-class-inside-objects-name
branch
from
db286e1
to
c7216b9
Compare
Signed-off-by: Andres Gomez Ferrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Escape
$from the task name. Normally task name is generated from the className and if the className is inside and scala object the result isObjectName$TaskName, so we need to scape the$to can execute the tasks properly.Tested:
Type
Are all requirements met?