Fix only apply last subworkflow mock #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Gomez Ferrer <[email protected]>
andresgomezfrr
force-pushed
the
fix-subworkflow-mocks
branch
from
f453fd7
to
f1e2cf3
Compare
pablocasares
approved these changes
Jan 22, 2024
Signed-off-by: Andres Gomez Ferrer <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Using the local executor if you try to mock subworkflow using
.withWorkflowOutput(...)multiple times for the same workflow. You always get the last mock output for all inputs. This PR tries to fix this behavior allowing you to apply different mock outputs per input.Type
Are all requirements met?
Complete description
To solve the issue we added a task inside the
TestingWorkflowutil to allow to compile and execute a workflow with a task with all of mocks, previously the TestingWorkflow was compiled by returning the output directly without an internal task, so when you applied multiple mocks to the same workflow, you always overwrite the workflowTemplate name with the last one.