Make plugin task first-class citizen #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3d9ab4e. Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
revert-271-revert-268-plugin-task
branch
from
1f4031f
to
9417e8b
Compare
Signed-off-by: Hongxin Liang <[email protected]>
|
I dropped the |
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
revert-271-revert-268-plugin-task
branch
from
bbd1248
to
70ad715
Compare
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
revert-271-revert-268-plugin-task
branch
from
b0d9b93
to
bd0d705
Compare
Signed-off-by: Hongxin Liang <[email protected]>
andresgomezfrr
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #268, which was not ready to get merged and got reverted later.
TL;DR
Create a dedicated Plugin Task instead of abusing Runnable Task.
Type
Are all requirements met?
Complete description
Manually pick proto change from unmerged PR Agent Sync Plugin flyte#4107We can go back to this later, for now I have removed this part to make this PR shippablerunreturningnullNote that it is still supported to use Runnable Task to implement tasks that are handled by backend plugin, for backward compatibility.
Tracking Issue
NA
Follow-up issue
NA