Recursively handle subworkflow in dynamic #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
subworkflow-in-dynamic
branch
from
572bd7d
to
27be6d4
Compare
honnix
commented
Oct 9, 2023
| List<Node> nodes, | ||
| Map<WorkflowIdentifier, WorkflowTemplate> allWorkflows, | ||
| Function<List<Node>, List<Node>> nodesRewriter) { | ||
| List<Node> rewrittenNodes = nodesRewriter.apply(nodes); |
There was a problem hiding this comment.
This is a bug fix because recursively collecting subworkflows doesn't work under dynamic task execution context.
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
subworkflow-in-dynamic
branch
from
988d91c
to
158ed81
Compare
andresgomezfrr
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Recursively handle subworkflow in dynamic
Type
Are all requirements met?
Complete description
Today subworkflow in dynamic task does not really work because we are not including all referenced task templates and propeller fails the compilation. This PR fixes that by recursively collecting all referenced task templates to include them in the dynamic job proto.
Tracking Issue
NA
Follow-up issue
NA