Align java examples with scala ones #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Jul 6, 2023
| import org.flyte.flytekit.jackson.JacksonSdkType; | ||
|
|
||
| @AutoService(SdkWorkflow.class) | ||
| public class SubWorkflow extends SdkWorkflow<SubWorkflow.Input, SubWorkflow.Output> { | ||
| public class SubWorkflow extends SdkWorkflow<WelcomeWorkflow.Input, WelcomeWorkflow.Output> { |
There was a problem hiding this comment.
This becomes exactly the same as Scala.
honnix
commented
Jul 6, 2023
| import org.flyte.flytekit.jackson.JacksonSdkType; | ||
|
|
||
| @AutoService(SdkWorkflow.class) | ||
| public class SumWorkflow extends SdkWorkflow<SumWorkflow.Input, SumWorkflow.Output> { |
There was a problem hiding this comment.
This was previously SubWorkflow in Java.
honnix
commented
Jul 6, 2023
| @@ -24,7 +24,7 @@ | |||
| import org.flyte.flytekit.jackson.JacksonSdkType; | |||
|
|
|||
| @AutoService(SdkWorkflow.class) | |||
| public class UberWorkflow extends SdkWorkflow<UberWorkflow.Input, SubWorkflow.Output> { | |||
| public class UberWorkflow extends SdkWorkflow<UberWorkflow.Input, SumWorkflow.Output> { | |||
There was a problem hiding this comment.
SubWorkflow to SumWorkflow change.
honnix
commented
Jul 6, 2023
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| /** Example workflow that takes a name and outputs a welcome message. */ | |||
| @AutoService(SdkWorkflow.class) | |||
| public class WelcomeWorkflow extends SdkWorkflow<WelcomeWorkflow.Input, AddQuestionTask.Output> { | |||
| public class WelcomeWorkflow extends SdkWorkflow<WelcomeWorkflow.Input, WelcomeWorkflow.Output> { | |||
There was a problem hiding this comment.
To align with Scala implementation.
pablocasares
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Align java examples with scala ones, for the subworkflow related things.
Type
Are all requirements met?
Complete description
It is a bit confusing that
SubWorkflowin Java and Scala carries different meaning for different purpose. So we align the Java one with Scala.Tracking Issue
NA
Follow-up issue
NA