Skip to content

Commit

Permalink
Revert "Make plugin task first-class citizen (#268)" (#271)
Browse files Browse the repository at this point in the history
This reverts commit 78cd22d.

Signed-off-by: Hongxin Liang <[email protected]>
  • Loading branch information
honnix authored Dec 11, 2023
1 parent 78cd22d commit 3d9ab4e
Show file tree
Hide file tree
Showing 15 changed files with 11 additions and 608 deletions.
8 changes: 0 additions & 8 deletions flyteidl-protos/src/main/proto/flyteidl/core/tasks.proto
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,6 @@ message RuntimeMetadata {

//+optional It can be used to provide extra information about the runtime (e.g. python, golang... etc.).
string flavor = 3;

//+optional It can be used to provide extra information for the plugin.
PluginMetadata plugin_metadata = 4;
}

message PluginMetadata {
//+optional It can be used to decide use sync plugin or async plugin during runtime.
bool is_sync_plugin = 1;
}

// Task Metadata
Expand Down
22 changes: 0 additions & 22 deletions flytekit-api/src/main/java/org/flyte/api/v1/PluginTask.java

This file was deleted.

This file was deleted.

8 changes: 0 additions & 8 deletions flytekit-api/src/main/java/org/flyte/api/v1/TaskTemplate.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
/**
* A Task structure that uniquely identifies a task in the system. Tasks are registered as a first
* step in the system.
*
* <p>FIXME: consider offering TaskMetadata instead of having everything in TaskTemplate, see
* https://github.com/flyteorg/flyte/blob/ea72bbd12578d64087221592554fb71c368f8057/flyteidl/protos/flyteidl/core/tasks.proto#L90
*/
@AutoValue
public abstract class TaskTemplate {
Expand Down Expand Up @@ -67,9 +64,6 @@ public abstract class TaskTemplate {
*/
public abstract boolean cacheSerializable();

/** Indicates whether to use sync plugin or async plugin to handle this task. */
public abstract boolean isSyncPlugin();

public abstract Builder toBuilder();

public static Builder builder() {
Expand All @@ -95,8 +89,6 @@ public abstract static class Builder {

public abstract Builder cacheSerializable(boolean cacheSerializable);

public abstract Builder isSyncPlugin(boolean isSyncPlugin);

public abstract TaskTemplate build();
}
}
115 changes: 0 additions & 115 deletions flytekit-java/src/main/java/org/flyte/flytekit/SdkPluginTask.java

This file was deleted.

This file was deleted.

Loading

0 comments on commit 3d9ab4e

Please sign in to comment.