Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add tag into ExecutionUpdateRequest #441

Closed
wants to merge 0 commits into from

Conversation

ericwudayi
Copy link

@ericwudayi ericwudayi commented Sep 18, 2023

TL;DR

As title

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Add tag string into ExecutionUpdateRequest proto

@welcome
Copy link

welcome bot commented Sep 18, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7f62a15) 75.92% compared to head (bac051f) 78.48%.
Report is 4 commits behind head on master.

❗ Current head bac051f differs from pull request most recent head 8802bb4. Consider uploading reports for the commit 8802bb4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   75.92%   78.48%   +2.55%     
==========================================
  Files          18       18              
  Lines        1458     1250     -208     
==========================================
- Hits         1107      981     -126     
+ Misses        294      212      -82     
  Partials       57       57              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant