Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

real time deck support #579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yicheng-Lu-llll
Copy link
Member

@Yicheng-Lu-llll Yicheng-Lu-llll commented Jun 22, 2023

TL;DR

This PR:

  1. stores DeckUri at task running stage to support real-time deck.
    with real time deck support flytepropeller#579, propeller can send node event with deck uri at running time, So, admin needs to also store the DeckUri inomation.

  2. In the CreateDownloadLink method, ensure to verify the existence of the URL prior to generating a signed URL. The console invokes CreateDownloadLink to convert the native deck URI into a signed URI. As indicated in FlytePropeller Pull Request #579, the deck URI may not exist yet, necessitating this validation step.

real time deck support includes:

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Yicheng-Lu-llll <[email protected]>
@Yicheng-Lu-llll Yicheng-Lu-llll changed the title [WIP]real time deck support real time deck support Jun 23, 2023
@Yicheng-Lu-llll Yicheng-Lu-llll marked this pull request as ready for review June 23, 2023 21:56
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #579 (02d399f) into master (949f5a2) will increase coverage by 1.53%.
The diff coverage is 46.66%.

❗ Current head 02d399f differs from pull request most recent head 4bbe0f8. Consider uploading reports for the commit 4bbe0f8 to get more accurate results

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   58.60%   60.14%   +1.53%     
==========================================
  Files         168      168              
  Lines       16256    13302    -2954     
==========================================
- Hits         9527     8000    -1527     
+ Misses       5887     4459    -1428     
- Partials      842      843       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dataproxy/service.go 60.32% <42.85%> (+2.21%) ⬆️
pkg/repositories/transformers/node_execution.go 75.30% <100.00%> (+2.75%) ⬆️

... and 153 files with indirect coverage changes

Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant