Add user name to UserInfoResponse header (#507)

flyteorg · Jan 10, 2023 · d6bc85d · d6bc85d
1 parent cb1224b
commit d6bc85d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/auth/handlers.go b/auth/handlers.go
@@ -450,6 +450,7 @@ func GetUserInfoForwardResponseHandler() UserInfoForwardResponseHandler {
 		info, ok := m.(*service.UserInfoResponse)
 		if ok {
 			w.Header().Set("X-User-Subject", info.Subject)
+			w.Header().Set("X-User-Name", info.Name)
 		}
 		return nil
 	}

diff --git a/auth/handlers_test.go b/auth/handlers_test.go
@@ -302,13 +302,18 @@ func TestUserInfoForwardResponseHander(t *testing.T) {
 	w := httptest.NewRecorder()
 	resp := service.UserInfoResponse{
 		Subject: "user-id",
+		Name:    "User Name",
 	}
 	assert.NoError(t, handler(ctx, w, &resp))
 	assert.Contains(t, w.Result().Header, "X-User-Subject")
 	assert.Equal(t, w.Result().Header["X-User-Subject"], []string{"user-id"})
 
+	assert.Contains(t, w.Result().Header, "X-User-Name")
+	assert.Equal(t, w.Result().Header["X-User-Name"], []string{"User Name"})
+
 	w = httptest.NewRecorder()
 	unrelatedResp := service.OAuth2MetadataResponse{}
 	assert.NoError(t, handler(ctx, w, &unrelatedResp))
 	assert.NotContains(t, w.Result().Header, "X-User-Subject")
+	assert.NotContains(t, w.Result().Header, "X-User-Name")
 }