add port, add nil checks

Signed-off-by: Yee Hing Tong <[email protected]>

pkg/artifacts/artifact_client.go

@@ -3,6 +3,7 @@ package artifacts
 import (
 	"context"
 	"crypto/tls"
+	"fmt"
 	"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/artifact"
 	"github.com/flyteorg/flytestdlib/logger"
 	"google.golang.org/grpc"
@@ -24,7 +25,7 @@ func NewArtifactConnection(_ context.Context, cfg *Config, opts ...grpc.DialOpti
 		opts = append(opts, grpc.WithTransportCredentials(creds))
 	}
 
-	return grpc.Dial(cfg.Host, opts...)
+	return grpc.Dial(fmt.Sprintf("%s:%d", cfg.Host, cfg.Port), opts...)
 }
 
 func InitializeArtifactClient(ctx context.Context, cfg *Config, opts ...grpc.DialOption) artifact.ArtifactRegistryClient {

pkg/manager/impl/execution_manager.go

@@ -712,8 +712,11 @@ func resolveSecurityCtx(ctx context.Context, executionConfigSecurityCtx *core.Se
 // ResolveLiteralMapArtifacts will go through the input literal map and resolve any artifact references to their
 // literal values.
 func (m *ExecutionManager) ResolveLiteralMapArtifacts(ctx context.Context, inputs *core.LiteralMap) (*core.LiteralMap, []*core.ArtifactID, error) {
-	// only top level replace for now.
 	var artifactIDs []*core.ArtifactID
+	if inputs == nil {
+		return nil, artifactIDs, nil
+	}
+	// only top level replace for now.
 	outputs := map[string]*core.Literal{}
 	for k, v := range inputs.Literals {
 		if v.GetArtifactId() != nil {
@@ -746,6 +749,9 @@ func (m *ExecutionManager) ResolveLiteralMapArtifacts(ctx context.Context, input
 func (m *ExecutionManager) ResolveParameterMapArtifacts(ctx context.Context, inputs *core.ParameterMap) (*core.ParameterMap, []*core.ArtifactID, error) {
 	// only top level replace for now.
 	var artifactIDs []*core.ArtifactID
+	if inputs == nil {
+		return nil, artifactIDs, nil
+	}
 	outputs := map[string]*core.Parameter{}
 	x := *m.artifactClient
 

pkg/manager/impl/validation/validation.go

@@ -256,7 +256,7 @@ func validateParameterMap(inputMap *core.ParameterMap, fieldName string) error {
 					"The Variable component of the Parameter %s in %s either is missing, or has a missing Type",
 					name, fieldName)
 			}
-			if defaultInput.GetDefault() == nil && !defaultInput.GetRequired() {
+			if defaultInput.GetDefault() == nil && defaultInput.GetArtifactQuery() == nil && !defaultInput.GetRequired() {
 				return errors.NewFlyteAdminErrorf(codes.InvalidArgument,
 					"Invalid variable %s in %s - variable has neither default, nor is required. "+
 						"One must be specified", name, fieldName)