Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to github for flytekit docs #5831

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

With this PR, the flytekit API docs will point to Github.

What changes were proposed in this pull request?

This PR adds a custom linkcode_resolve to link back to flytekit code.

How was this patch tested?

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.35%. Comparing base (da2ce74) to head (9ec2a5e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5831   +/-   ##
=======================================
  Coverage   36.34%   36.35%           
=======================================
  Files        1304     1304           
  Lines      110148   110148           
=======================================
+ Hits        40037    40042    +5     
+ Misses      65944    65939    -5     
  Partials     4167     4167           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (+0.03%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett merged commit 0100fcd into flyteorg:master Oct 9, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants