Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal version to failure nodes docs #5812

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Oct 4, 2024

Tracking issue

Closes #5811

Why are the changes needed?

A user in the OSS slack was confused when their failure node workflow didn't work.

What changes were proposed in this pull request?

Add a warning to the failure nodes docs page.

How was this patch tested?

Setup process

Screenshots

Screenshot 2024-10-04 at 2 47 19 PM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.35%. Comparing base (b9900fe) to head (d5af4ee).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5812   +/-   ##
=======================================
  Coverage   36.35%   36.35%           
=======================================
  Files        1304     1304           
  Lines      110147   110147           
=======================================
  Hits        40042    40042           
  Misses      65938    65938           
  Partials     4167     4167           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@chenyuan99 chenyuan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neverett
Copy link
Contributor

neverett commented Oct 7, 2024

@eapolinario I think you need to merge master in to your branch to fix the docs test failure, but lmk if that doesn't do the trick.

@eapolinario eapolinario merged commit 604be4a into master Oct 8, 2024
50 checks passed
@eapolinario eapolinario deleted the add-minimal-version-to-failure-nodes-docs branch October 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Add a note to mention the minimal versions required to run failure nodes
4 participants