Add Flyin propeller config #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f ArrayNode (#4535)" This reverts commit b50ba87. Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
size:L
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4610 +/- ##
=======================================
Coverage 59.01% 59.02%
=======================================
Files 622 622
Lines 52739 52775 +36
=======================================
+ Hits 31123 31148 +25
- Misses 19133 19140 +7
- Partials 2483 2487 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
hamersaw
approved these changes
Dec 20, 2023
EngHabu
reviewed
Dec 20, 2023
Comment on lines
+31
to
+33
| IsFlyinEnabled bool `json:"flyin-enabled" pflag:",Enable Log-links to flyin logs"` | ||
| FlyinTemplateURI tasklog.TemplateURI `json:"flyin-template-uri" pflag:",Template Uri to use when building flyin log links"` | ||
|
|
There was a problem hiding this comment.
Why is this specific to flyin? This should be a map of string & tasklog.TemplateLogPlugin... task templates should be able to enable any number of them
There was a problem hiding this comment.
We sync'd offline and the idea is to make this more extensible by providing a way for tasks to dynamically set log links. I'll be sending a follow up PR shortly.
eapolinario
added a commit
that referenced
this pull request
Jan 24, 2024
This reverts commit 3501675. Signed-off-by: Eduardo Apolinario <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#4284
Why are the changes needed?
We want a way to expose a log link in the case of tasks that use the flyin plugin
What changes were proposed in this pull request?
Expose a
flyin-enabledpflag and ensure that only tasks that fill the task template with the appropriate config get a Flyin log.How was this patch tested?
Unit tests and a smoke test with single-binary running locally.
Setup process
Screenshots
Ran this workflow:
The task that's using the
@vscodedecorator:And the other task:
Check all the applicable boxes
Related PRs
Docs link