Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ray Autoscaler to the Flyte-Ray plugin #4363

Merged
merged 15 commits into from
Dec 26, 2023

Conversation

Yicheng-Lu-llll
Copy link
Member

@Yicheng-Lu-llll Yicheng-Lu-llll commented Nov 6, 2023

Tracking issue

#4187

Describe your changes

Add Ray Autoscaler config to the Flyte-Ray plugin. See flyteorg/flytekit#1937 for motivations and detail examples.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (853ebe4) 59.01% compared to head (6d4f35a) 59.02%.

Files Patch % Lines
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
+ Coverage   59.01%   59.02%   +0.01%     
==========================================
  Files         622      622              
  Lines       52816    52823       +7     
==========================================
+ Hits        31169    31181      +12     
+ Misses      19156    19151       -5     
  Partials     2491     2491              
Flag Coverage Δ
unittests 59.02% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 22, 2023
@eapolinario eapolinario merged commit 0e35cab into flyteorg:master Dec 26, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants