Add Agent Minio Credential for Sensor Agent #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Oct 16, 2023
| env: | ||
| - name: FLYTE_AWS_ENDPOINT | ||
| valueFrom: | ||
| secretKeyRef: |
There was a problem hiding this comment.
It's not necessary to use secretKeyRef, just use value here.
Signed-off-by: Future Outlier <[email protected]>
added 2 commits
October 17, 2023 20:22
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
changed the title
added 2 commits
October 17, 2023 22:18
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Oct 18, 2023
added 2 commits
October 18, 2023 16:20
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
pingsutw
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
flyteorg/flytesnacks#1180
Describe your changes
Now we can use the sensor agent without setting the Minio credential.
You can test it with my new image.
Check all the applicable boxes
Screenshots