Skip to content

Commit

Permalink
Fix extraArgs templating in deployments (#2835)
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Dye <[email protected]>
  • Loading branch information
andrewwdye authored Sep 6, 2022
1 parent 0b3273f commit 5f801cd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/flyte-core/templates/admin/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ spec:
- {{ .Values.flyteadmin.configPath }}
- serve
{{- with .Values.flyteadmin.extraArgs }}
{{- tpl (toYaml $) . | nindent 6 }}
{{- tpl (toYaml .) $ | nindent 8 }}
{{- end }}
{{- if .Values.flyteadmin.env }}
env:
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-core/templates/datacatalog/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
- {{ .Values.datacatalog.configPath }}
- serve
{{- with .Values.datacatalog.extraArgs }}
{{- tpl (toYaml $) . | nindent 6 }}
{{- tpl (toYaml .) $ | nindent 8 }}
{{- end }}
image: "{{ .Values.datacatalog.image.repository }}:{{ .Values.datacatalog.image.tag }}"
imagePullPolicy: "{{ .Values.datacatalog.image.pullPolicy }}"
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-core/templates/propeller/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
- {{ tpl (toYaml .) $ }}
{{- end -}}
{{- with .Values.flytepropeller.extraArgs }}
{{- tpl (toYaml $) . | nindent 6 }}
{{- tpl (toYaml .) $ | nindent 8 }}
{{- end }}
env:
- name: POD_NAME
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-core/templates/propeller/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ template:
- --config
- {{ .Values.flytepropeller.configPath }}
{{- with .Values.flytepropeller.extraArgs }}
{{- tpl (toYaml $) . | nindent 6 }}
{{- tpl (toYaml .) $ | nindent 6 }}
{{- end }}
env:
- name: POD_NAME
Expand Down

0 comments on commit 5f801cd

Please sign in to comment.