Add version control for ArrayNode eventing (#4165)

* added version control of ArrayNode eventing Signed-off-by: Daniel Rammer <[email protected]> * correctly sending initializing status for subtasks Signed-off-by: Daniel Rammer <[email protected]> * handling abort eventing Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests Signed-off-by: Daniel Rammer <[email protected]> * fixed lint issues Signed-off-by: Daniel Rammer <[email protected]> * adding IsArray flag to NodeExecutionMetadata Signed-off-by: Daniel Rammer <[email protected]> * fixed propeller generate Signed-off-by: Daniel Rammer <[email protected]> * fixed merging issues Signed-off-by: Daniel Rammer <[email protected]> * make generate for arraynode mocks Signed-off-by: Daniel Rammer <[email protected]> * removed dead code Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
flyteorg · Oct 9, 2023 · 4a780c3 · 4a780c3
1 parent 8d66d05
commit 4a780c3
Show file tree

Hide file tree

Showing 40 changed files with 1,429 additions and 668 deletions.
diff --git a/flyteadmin/pkg/repositories/transformers/node_execution.go b/flyteadmin/pkg/repositories/transformers/node_execution.go
@@ -131,6 +131,7 @@ func CreateNodeExecutionModel(ctx context.Context, input ToNodeExecutionModelInp
 		SpecNodeId:   input.Request.Event.SpecNodeId,
 		IsParentNode: input.Request.Event.IsParent,
 		IsDynamic:    input.Request.Event.IsDynamic,
+		IsArray:      input.Request.Event.IsArray,
 	}
 	err := handleNodeExecutionInputs(ctx, nodeExecution, input.Request, input.StorageClient)
 	if err != nil {
@@ -304,6 +305,9 @@ func UpdateNodeExecutionModel(
 		if request.Event.IsDynamic {
 			nodeExecutionMetadata.IsDynamic = true
 		}
+		if request.Event.IsArray {
+			nodeExecutionMetadata.IsArray = true
+		}
 		nodeExecMetadataBytes, err := proto.Marshal(&nodeExecutionMetadata)
 		if err != nil {
 			return errors.NewFlyteAdminErrorf(codes.Internal,

diff --git a/flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.cc b/flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.cc
diff --git a/flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.h b/flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.h