Skip to content

Commit

Permalink
New Deck IDL (#6175)
Browse files Browse the repository at this point in the history
* New Deck IDL

Signed-off-by: Future-Outlier <[email protected]>

* lint

Signed-off-by: Future-Outlier <[email protected]>

* make -C flyteidl generate

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Future-Outlier and eapolinario authored Jan 16, 2025
1 parent d994964 commit 1d9cf5f
Showing 12 changed files with 377 additions and 345 deletions.
8 changes: 4 additions & 4 deletions flyteidl/clients/go/assets/admin.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 13 additions & 9 deletions flyteidl/gen/pb-es/flyteidl/core/tasks_pb.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

483 changes: 247 additions & 236 deletions flyteidl/gen/pb-go/flyteidl/core/tasks.pb.go

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions flyteidl/gen/pb-js/flyteidl.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 19 additions & 17 deletions flyteidl/gen/pb-js/flyteidl.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

103 changes: 52 additions & 51 deletions flyteidl/gen/pb_python/flyteidl/core/tasks_pb2.py

Large diffs are not rendered by default.

9 changes: 5 additions & 4 deletions flyteidl/gen/pb_python/flyteidl/core/tasks_pb2.pyi

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions flyteidl/gen/pb_rust/flyteidl.core.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions flyteidl/protos/flyteidl/core/tasks.proto
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ import "flyteidl/core/literals.proto";
import "flyteidl/core/security.proto";
import "google/protobuf/duration.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/wrappers.proto";

package flyteidl.core;

@@ -88,6 +89,10 @@ message RuntimeMetadata {

// Task Metadata
message TaskMetadata {
// Field number 10 is reserved because we are reusing the name generates_deck for field number 15,
// but with a different type.
reserved 10;

// Indicates whether the system should attempt to lookup this task's output to avoid duplication of work.
bool discoverable = 1;

@@ -121,9 +126,6 @@ message TaskMetadata {
// Indicates whether the system should attempt to execute discoverable instances in serial to avoid duplicate work
bool cache_serializable = 9;

// Indicates whether the task will generate a Deck URI when it finishes executing.
bool generates_deck = 10;

// Arbitrary tags that allow users and the platform to store small but arbitrary labels
map<string, string> tags = 11;

@@ -137,6 +139,13 @@ message TaskMetadata {
// is_eager indicates whether the task is eager or not.
// This would be used by CreateTask endpoint.
bool is_eager = 14;

// Indicates whether the task will generate a deck when it finishes executing.
// The BoolValue can have three states:
// - nil: The value is not set.
// - true: The task will generate a deck.
// - false: The task will not generate a deck.
google.protobuf.BoolValue generates_deck = 15;
}

// A Task structure that uniquely identifies a task in the system

0 comments on commit 1d9cf5f

Please sign in to comment.