migration: fix crash due to failed heartbeats not propagating #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpausp
approved these changes
Nov 20, 2023
tests: reduce test flakiness This introduces pytest-patterns as a replacement for the current use of Ellipsis. Increase general timeouts so tests are a bit less flaky. Improve some lock logging to make it easier to understand and debug when reading the locks and I think this also fixes some race conditions. Fix VM kill handling to include our little supervisor process and selectively decide whether to kill it or not. Add more testing output about the environment in case something goes wrong in the tests and we need to debug it. Fixes PL-131744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PL-131744