Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] fc.qemu: update to reduce test flakiness #1118

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ctheune
Copy link
Contributor

@ctheune ctheune commented Sep 26, 2024

Re PL-133015

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whe
    ther the default should be on or off. Example: rate limiting.

not needed

  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

not customer facing

Security implications

reliability of our workflows to ensure ability to act

  • Security requirements tested? (EVIDENCE)

tests work, but flakiness will be proven over time

@osnyx osnyx merged commit 423ccca into fc-21.05-dev Sep 26, 2024
1 check passed
@osnyx osnyx deleted the PL-133015-improve-kvm-test-stability branch September 26, 2024 14:52
@dpausp dpausp changed the title fc.qemu: update to reduce test flakiness [21.05] fc.qemu: update to reduce test flakiness Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants