[fix] Fix OCI Version handling + passing entrypoint #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilTaken
changed the title
PhilTaken
force-pushed
the
phil/fix-oci-template
branch
5 times, most recently
from
5a69f5d
to
6777dd7
Compare
zagy
requested changes
Aug 8, 2023
| entrypoint = "{{component.entrypoint}}"; | ||
| # {% endif %} | ||
|
|
||
| # {% if component.docker_cmd %} | ||
| cmd = [ {% for cmd in component.docker_cmd.split(" ") %} "{{cmd}}" {% endfor %} ]; |
There was a problem hiding this comment.
I'm pretty sure this will fail sooner or later. You probably want to use shlex.split()
There was a problem hiding this comment.
that's a very good point, just added that functionality
PhilTaken
force-pushed
the
phil/fix-oci-template
branch
from
6777dd7
to
087e77b
Compare
this fixes version handling when doing so seperately from the image string as well as passing an entrypoint to the image. the nixos module requires the `entrypoint` to be a single file in PATH and all arguments for that file in `cmd`.
PhilTaken
force-pushed
the
phil/fix-oci-template
branch
from
087e77b
to
5a9308f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes version handling when doing so seperately from the image string as well as passing an entrypoint to the image. the nixos module requires the
entrypointto be a single file in PATH and all arguments for that file incmd.slightly related to this: we might need tight(er) unit tests to catch mistakes like these