Ignore currently running backup for SLA calculation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already the case (due to a bug) for a long time, but was recently fixed in #37. This commit reintroduces this behaviour. The reasoning is that a backup which takes longer than 50% (grace period) of the configured interval indicates a problem with the backup server/network/etc...
ctheune
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already the case (due to a bug) for a long time, but was recently fixed in #37.
This commit reintroduces this behaviour.
The reasoning is that a backup which takes longer than 50% (grace period) of the configured interval indicates a problem with the backup server/network/etc...
Related issue(s): PL-132625
Security implications
No specific security requirements. Bugfix to reintroduce previous behaviour.
Added test coverage.