switch to pathlib and improve type checking #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 6, 2024 01:33
also add more typehints
It is now possible to open a revision with any (supported) backend type, instead of only supporting the current default backend.
The parent of a revision was previously selected independently of additional source constraints. This could result in a revision C having the parent B, but with a delta of A -> C applied by the source (e.g. the snapshot for B is missing). This did not cause any issues until now because ceph always includes the chunks of the delta B->C in A->C (even when A->B is the inverse of B->C), but we should not rely on this behaviour. The file source also gained the ability to select a trusted parent instead of falling back to a non-cow copy when a distrusted revision exists.
ctheune
reviewed
Apr 8, 2024
ctheune
previously approved these changes
Apr 8, 2024
dhnasa
commented
Apr 8, 2024
ctheune
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s): -
support mixed backends
It is now possible to open a revision with any (supported) backend type,
instead of only supporting the current default backend.
use the same parent revision in source and backend
The parent of a revision was previously selected independently of
additional source constraints. This could result in a revision C having
the parent B, but with a delta of A -> C applied by the source (e.g.
the snapshot for B is missing).
This did not cause any issues until now because ceph always includes
the chunks of the delta B->C in A->C (even when A->B is the inverse of
B->C), but we should not rely on this behaviour.
The file source also gained the ability to select a trusted parent
instead of falling back to a non-cow copy when a distrusted revision
exists.
Security implications