Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace telnet shell with http api #42

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Replace telnet shell with http api #42

merged 1 commit into from
Nov 2, 2023

Conversation

dhnasa
Copy link
Collaborator

@dhnasa dhnasa commented Jun 19, 2023 •
edited
Loading

in preparation for #37

  • update wiki
  • Change is documented in changelog

  • Replace prettytable with rich

  • Replace telnet shell with HTTP API

  • Migrate backy check to backy client check and use the new HTTP API (breaking)

Security implications

  • no unauthenticated access
    • every request needs a token

@dhnasa dhnasa changed the title Replace telnet with http Replace telnet shell with http api Jun 19, 2023
@dhnasa
Copy link
Collaborator Author

dhnasa commented Aug 25, 2023

Daemon no longer logs sla violations on its own. Is this a problem?

@ctheune ctheune marked this pull request as draft August 31, 2023 11:56
@ctheune ctheune marked this pull request as ready for review August 31, 2023 11:56
@dhnasa dhnasa force-pushed the replace-telnet-with-http branch 4 times, most recently from 0d24394 to f0fdbe5 Compare September 6, 2023 19:18
@dhnasa dhnasa force-pushed the replace-telnet-with-http branch 2 times, most recently from b5489aa to f621f48 Compare September 7, 2023 22:18
@dhnasa dhnasa force-pushed the replace-telnet-with-http branch 3 times, most recently from 8fdbbc0 to 3d6501f Compare October 5, 2023 13:13
ctheune
ctheune requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. There's a few minor changes I'd like to see and the test coverage for the token authentication should be extended.

src/backy/api.py Outdated Show resolved Hide resolved
src/backy/api.py Outdated Show resolved Hide resolved
src/backy/api.py Outdated Show resolved Hide resolved
src/backy/api.py Show resolved Hide resolved
src/backy/api.py Outdated Show resolved Hide resolved
src/backy/client.py Outdated Show resolved Hide resolved
src/backy/main.py Outdated Show resolved Hide resolved
src/backy/tests/test_daemon.py Show resolved Hide resolved
@ctheune
Copy link
Contributor

ctheune commented Oct 19, 2023

Getting there ... :)

@ctheune ctheune merged commit fea08cb into main Nov 2, 2023
3 checks passed
@dhnasa dhnasa deleted the replace-telnet-with-http branch November 2, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctheune ctheune ctheune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhnasa @ctheune